Conference koolit::vms_curriculum

    
    	A draft of the fifth Sysnet II chapter entitled:
    
    		Designing Command Procedures
    
    		is available for review in:
    
    		SUPER::ES$REVIEW:[SYSNET_II]SYSNETII_CHAP5.PS
    
    			Wendy

    Review comments on the chapter:
    
    		Designing Command Procedures
    
    Page	Comment
    ----	-------
    1-13	Final heading should be "EXIT Versus ENDSUBROUTINE"
    
    1-15	Text on A.COM - LST hasn't been defined - Local
    		Symbol Table
    
    1-18	Presumably the callout numbering runs on because of the
    		links between the caller and callee. Threw me initially -
    		I guess its the interruption of flow caused by instructor
    		pages (and I've got paper printed two up, two sided).
    
    1-27	The dangers of turning off CONTROL-Y cannot be
    		overstressed. Untested or indiscriminate use can (and does)
    		have an impact on a system and users thereof.

                        Module 5
                 Designing Command Procedures

1-6 Why do you put the label CLEANUP: in this example?
You never go to the label at any point. I know this example is in other
student guides right now, but I would take out that label. People
ask its purpose.

1-8 Maybe put the example in here using Inquire to do the same thing this 
example is doing. That example is also I beleive in the u an d c II student
guide and the smgtII student guide (the example of p1 and inquire)
The reason I mentioned this is so you could get another example with INQUIRE.

1-15 Good examples of call and gosub

1-18 I think this example is confusing and I don't like it at all.
It in two other courses right now that I know of and its hard to follow.
It always looses the class.

1-21 Error hanlding is good

	Review of chapter:

	DESIGNING COMMAND PROCEDURES

Page 1-6: Example 4-1.
          Comment section is on the end of the command procedure.
	  Why not putting in the header section. Same as we do with the startup
	  procedures.
	  There is also an other benefit. You can search faster through command
	  procedures to find the right one. Use $SEARCH/WINDOW=(n1,n2) n1 =
	  lines before and n2 is line after

	  Use of label CLEANUP: leave it away, or use also label in the
	  beginning BEGIN:

	  line $DIR/GRAND/SIZE=ALL     use the full syntax
               $DIRECTORY/GRAND_TOTAL/SIZE=ALL

Page 1-10: Missing format 4
          
           I know this is not a preferred syntax, but still a way to do it.

           IF  ...  THEN   command    ELSE   command

Page 1-13: second bullet  In the format   \bold (this belongs to document?)

           last bullet   ENDROUTINE --->  ENDSUBROUTINE.

Page 1-15:  Example is okay.
            Could the layout be changed?
	    Like this.

            $ A = 5                  $ A = 5
            $ B = 5                  $ B = 5
            $	CALL add A B         $	GOSUB add
            $	SHOW symbol C        $	SHOW symbol C
            $ EXIT                   $ EXIT
            $add:  SUBROUTINE        $add:
            $	C == P1 + P2         $	C = A +B
            $   EXIT                 $  RETURN
            $   ENDSUBROUTINE        

	    Then the procedure is a little bit more readable.

Page 1-21: Last line.   SET NO CONTROL = Y  syntax wrong
                        SET NOCONTROL = Y
           Do we have to mention also the Lexical F$MESSAGE here?
           You can refer the chapter 3.

Page 1-28: Example 4-10 Layout.
	   
	   After label READ_LOOP:  following three line also starting with a
				   TAB
           Same as you did after the label NO_FILE: and DONE:

So far thie review.

Arjen.
    

    
    	The two week time period for reviews is over.
    
    	Any comments entered after this note will be considered, time
    permitting.
    
    				Wendy

	Designing Command Procedures
	Chapter 5

1-7	Define for the student that p1 through p8 are  symbols
  	within command procedures.

1-10a	Fourth bullet - I'm not really clear what you are trying to
	say.  Maybe an example of what will and what will not work
	with the IF-THEN-ENDIF statements.

1-12	How about including an IF-THEN-GOTO example?

1-13	In the line with the general format. Notice the \bold) that
	doesn't belong.

1-14a	Please include in the instructor's notes an example of how the
	RETURN %X1 is used.  What you have so far is not complete.

1-15	Maybe include the output from each command procedure.

1-21	I really like this page.  Good summary.

Lynn White
Washington D.C.

I think the revised draft addresses all the comments except these two,
which I didn't have time to do in this pass:

> 1-12    How about including an IF-THEN-GOTO example?

> 1-15    Maybe include the output from each command procedure.