| T.R | Title | User | Personal
Name | Date | Lines |
|---|
| 21.1 | draft ready for review | HARDY::BUNNELL | | Mon Dec 10 1990 12:33 | 5 |
| A draft of this module is available for review in:
super::es$review:[ra0294]ra0294_chap_3_profile.ps
Hannah
|
| 21.2 | Reading, UK - first pass | UKEDU::SHONE | Keith Shone @RKA 830-4074 | Thu Dec 13 1990 10:30 | 25 |
| I found the flow of this chapter OK.
My nits, typos and other observations are below.
NOTE: These are my feelings etc. not of the UK as a whole.
I comment on typos etc on instructor pages as well as customer pages.
Instructors deserve to have unambiguous, correctly spelled and
technically accurate information too! :-)
Some text missing from the review copy
Page Observation
---- -----------
1-7a Awkward first sentence, suggest:
"Note that this table merely lists the ways to create
symbols."
1-10a Line 4 of text: Typo: conversation -> conversion
1-11 Figure 1-1 missing
1-12 Beneath table: markmarkmarkmark !
Following two bullets repeated.
|
| 21.3 | Updated version ready for review | HARDY::BUNNELL | | Fri Dec 21 1990 13:50 | 8 |
| There is an updated version of this in
super::es$review:[ra0294]ra0294_chap_3_profile.ps
I added the figures, the previous comments and a section on SHOW
SYMBOL.
Hannah
|
| 21.4 | UK - a few more nits/typos | PEKING::SHONEK | | Mon Jan 14 1991 11:49 | 61 |
| A few points to ponder, listed below.
There's plenty of information in this module. I particularly
liked the section on overlays - mostly because I never use them
and never had to explain them either!
Page Observation
---- -----------
1-7a Last line: in in -> is in
1-10 Line 4 of Comments column:
Need a fullstop after levels and before Finally.
That sentence might be better as:
"Finally the global symbol table is searched."
Pedantic observation but last couple of lines in this
table state that "...TIME currently has no value".
Strictly TIME is undefined. (I did say it was going
to be pedantic!)
1-12a Line 4: conversation -> conversion
1-15 Heading "String Manipulation Rules" should appear
immediately beneath table and second pair of bullets
should be deleted - they're a repetition of the first
pair of bullets.
1-16 How about an example to show the need to repeat
subtractions on a string? For example:
Time = 16:30:01.24
Time = Time - ":" - ":" - "."
Result: 16300124
(This used to be really handy in the days before VMS V4
when one couldn't use a date string for file names.
Strictly speaking, one couldn't use hyphens in
file names.
E.g. 14-JAN-1991 was illegal for a file name so
we used to use "14-JAN-1991" - "-" - "-" to yield
14JAN1991 which was, and still is valid for a filename)
1-28 The output here doesn't match the command procedure
There should be another line of output thus:
$ @REPORT3
Day to print a reportTUESDAY ! this line is missing
Day to print report for: TUESDAY
.
.
.
The reason for no space in the prompt message is
there isn't a space at the end of the prompt!
-- Keith
|
| 21.5 | VMS for adv. appl. users, review chapter 3 | NWGEDU::JANSSEN | | Wed Jan 16 1991 07:37 | 68 |
| Hi Hannah,
I reviewed the second version of this chapter and these are my comments:
1) Delete the topic "Symbol overlays", My opinion is that this topic is
going too far for an adv. appl user.
2) On page 1-7 you talk about local and global symbols, but de
explanation of those word are on page 1-12 and this is too late.
Replace the subject "Types of symbols" from page 1-12 till 1-14
after the subject "Creating symbols".
3) Give a few examples about deleting symbols, also using symbols
declared with a wildcard.
4) Exchange table 1-6 on page 1-13 with figure 1-1 on page 1-14, while
table 1-16 is a sort of summary about local and global symbols.
5) Include into figure 1-1 the local and global table in which the
symbols are placed.
ie.:
$ L = 0 A.COM B.COM
$ G == "demo" |----> $ L = -1 |----> $ SHOW SYMBOL L
$ @A.COM ----- $ @B.COM ---- $ SHOW SYMBOL G
$ SHOW SYMBOL L <--| $ SHOW SYMBOL G <-| $ L = -2
$ SHOW SYMBOL G |___$ EXIT | $ SHOW SYMBOL L
| $ G == "file" ----|
| $ SHOW SYMBOL G |
|_$ EXIT |
|
|
L.S.T level 0 L.S.T. level 1 L.S.T. level 2 |
___________________ _______________ __________________ |
| L = 0 | | L = -1 | | L = -2 | |
| | | | | | |
|___________________| |_______________| |__________________| |
|
|
G.S.T for all levels |
_____________________________________________________________ |
| G == "demo" | |
| strike out the previous value | |
| G == "file" <--------------------------------------------|
| |
| |
|_____________________________________________________________|
Try to give the output of the commands SHOW SYMBOL .... in this figure.
6) Give more explanation about 111.....11100 is equal to -4
(instructorpage 1.22a)
7) Give on page 1-22 the same table 1-16 as on page 1.22a.
8) Give an example of the usage of the order of precedence of
operators.
9) The two apostrophes are not clear on page 1-26, they look like
quotation marks.
10) Give an example for each phase of command processing on page 1-29.
Ed.
|
| 21.6 | Some comments from Denmark | COPCLU::SVENDSEN | | Thu Jan 24 1991 08:23 | 31 |
| Review of RA0294 Chapter 3 ---------------------------
It would be better to introduce symbols by telling that they are used
to abbriviate DCL-commands, and as local variables i command
procedures. This would make the purpose of the chapter more obvious.
It should me mentioned that you can use national characters in symbol
names.
Overall in the chapter the normalized text assignment (:==) should be
used, when the issue is command abbrev.
Examples should be used to clarify the contents of table 1-1.
The table 1-2 should emphasize the diffrence between :==text and
=="text"
The abbrev page is very nice.
Table 1-6 should emphasize that local symbols are generally used as
variables in a command procedure, and the reason why
The part about symbol manipulation is excellent.
The part about symbol substitution should give an explanation of the
reason for the usage of two '-s in textstrings, as it is not logical.
The more advanced techniques concerning symbol substitution should be
exemplified.
|